Re: Fix 035_standby_logical_decoding.pl race conditions - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fix 035_standby_logical_decoding.pl race conditions
Date
Msg-id Z_Xjaqw6L60MkiHY@paquier.xyz
Whole thread Raw
In response to Re: Fix 035_standby_logical_decoding.pl race conditions  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Fix 035_standby_logical_decoding.pl race conditions
List pgsql-hackers
On Tue, Apr 08, 2025 at 06:42:53AM +0000, Bertrand Drouvot wrote:
> Fully agree. Will need to find another way to prevent a process to wait between the
> wakeup and the detach. I'll open a dedicated thread.

By the way, there is a small thing that's itching me a bit about the
change done in LogStandbySnapshot() for 105b2cb33617.  Could it be
useful for debugging to add a elog(DEBUG1) with the LSN returned by
GetInsertRecPtr() when taking the short path?  We don't have any
visibility when the shortcut path is taken, which seems annoying in
the long term if we use the injection point skip-log-running-xacts for
other tests, and I suspect that there will be some as the standby
snapshots can be really annoying in tests where we want a predictible
set of WAL records when wal_level is "replica" or "logical".
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Next
From: Michael Paquier
Date:
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)