Re: Is WAL_DEBUG related code still relevant today? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Is WAL_DEBUG related code still relevant today?
Date
Msg-id ZXAODlUu0GBukrAu@paquier.xyz
Whole thread Raw
In response to Re: Is WAL_DEBUG related code still relevant today?  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Dec 04, 2023 at 10:14:36AM +0900, Michael Paquier wrote:
> I can add the flag in one of my nix animals if we don't have any to
> provide minimal coverage, that's not an issue for me.  I'd suggest to
> just fix the build on Windows, this flag is a low maintenance burden.

Hearing nothing about that, I've reproduced the failure, checked that
the proposed fix is OK, and applied it down to 13 where this was
introduced.

Regarding the tests, like Noah, I am not really sure that it is worth
spending resources on fixing as they'd require wal_debug = on to
break.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: logical decoding and replication of sequences, take 2
Next
From: Michael Paquier
Date:
Subject: Re: reindexing an invalid index should not use ERRCODE_INDEX_CORRUPTED