Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.
Date
Msg-id ZWUorvNaPB0BzCK_@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Add CHECK_FOR_INTERRUPTS in scram_SaltedPassword loop.  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Mon, Nov 27, 2023 at 10:05:49AM +0100, Daniel Gustafsson wrote:
> I don't see any reason to backpatch further down than 16 given how low the
> hardcoded value is set there, scanning the archives I see no complaints about
> it either.  As a reference, CREATE ROLE using 4096 iterations takes 14ms on my
> 10 year old laptop (1M iterations, 244x the default, takes less than a second).

Agreed, so done it this way.  \password has the same problem, where we
could perhaps do something with a callback or something like that, or
perhaps that's just not worth bothering.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jeremy Schneider
Date:
Subject: Re: proposal: change behavior on collation version mismatch
Next
From: Michael Paquier
Date:
Subject: Re: Incorrect comment in tableam.h regarding GetHeapamTableAmRoutine()