Re: Fix use of openssl.path() if openssl isn't found - Mailing list pgsql-hackers

On Tue, Nov 07, 2023 at 04:06:56PM -0600, Tristan Partin wrote:
> Found this issue during my Fedora 39 upgrade. Tested that uninstalling
> openssl still allows the various ssl tests to run and succeed.

Good catch.  You are right that this is inconsistent with what we
expect in the test.

> +openssl_path = ''
> +if openssl.found()
> +  openssl_path = openssl.path()
> +endif
> +
>  tests += {
>    'name': 'ssl',
>    'sd': meson.current_source_dir(),
> @@ -7,7 +12,7 @@ tests += {
>    'tap': {
>      'env': {
>        'with_ssl': ssl_library,
> -      'OPENSSL': openssl.path(),
> +      'OPENSSL': openssl_path,
>      },
>      'tests': [
>        't/001_ssltests.pl',

Okay, that's a nit and it leads to the same result, but why not using
the same one-liner style like all the other meson.build files that
rely on optional commands?  See pg_verifybackup, pg_dump, etc.  That
would be more consistent.
--
Michael