Re: 003_check_guc.pl crashes if some extensions were loaded. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: 003_check_guc.pl crashes if some extensions were loaded.
Date
Msg-id ZULW3m1h5K5PvSoD@paquier.xyz
Whole thread Raw
In response to 003_check_guc.pl crashes if some extensions were loaded.  ("Anton A. Melnikov" <a.melnikov@postgrespro.ru>)
Responses Re: 003_check_guc.pl crashes if some extensions were loaded.
List pgsql-hackers
On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote:
> Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an extension
> that adds own GUCs was loaded into memory.
> So it is now impossible to run a check-world with loaded extension libraries.

Right.  That's annoying, so let's fix it.

> --- a/src/test/modules/test_misc/t/003_check_guc.pl
> +++ b/src/test/modules/test_misc/t/003_check_guc.pl
> @@ -19,7 +19,7 @@ my $all_params = $node->safe_psql(
>         "SELECT name
>       FROM pg_settings
>     WHERE NOT 'NOT_IN_SAMPLE' = ANY (pg_settings_get_flags(name)) AND
> -       name <> 'config_file'
> +       name <> 'config_file' AND name NOT LIKE '%.%'
>       ORDER BY 1");

Wouldn't it be better to add a qual as of "category <> 'Customized
Options'"?  That's something arbitrarily assigned for all custom GUCs
and we are sure that none of them will exist in
postgresql.conf.sample.  There's also no guarantee that out-of-core
custom GUCs will include a dot in their name (even if I know that
maintainers close to the community adopt this convention and are
rather careful about that).
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Guiding principle for dropping LLVM versions?
Next
From: Michael Paquier
Date:
Subject: Re: Commitfest manager November 2023