Re: Add support for AT LOCAL - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add support for AT LOCAL
Date
Msg-id ZS4oykeg1ydoTM0W@paquier.xyz
Whole thread Raw
In response to Re: Add support for AT LOCAL  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add support for AT LOCAL
List pgsql-hackers
On Tue, Oct 17, 2023 at 01:40:18AM -0400, Tom Lane wrote:
> makes the failure go away.  Unfortunately, I've not yet found another
> way to make it go away :-(.  My upthread idea of using a local variable
> instead of result->time is no help, and some other random code
> alterations didn't change the results either.

That may be a long shot, but even a modulo?  Say in these two code
paths:
-   while (result->time >= USECS_PER_DAY)
-       result->time -= USECS_PER_DAY;
+   if (result->time >= USECS_PER_DAY)
+       result->time %= USECS_PER_DAY;

> Not sure where we go from here.  While I don't have much hesitation
> about blowing off xlc_r 12.1, it would be sad if their latest
> toolchain doesn't work either.  (I didn't try permuting the code
> while using the newer compiler, though.)

We've spent a lot of time on that.  I'm OK to just give up, trim the
values of the view with a qual, and call it a day.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Donghang Lin
Date:
Subject: Re: interval_ops shall stop using btequalimage (deduplication)
Next
From: Amit Kapila
Date:
Subject: Re: pg_logical_emit_message() misses a XLogFlush()