Re: pg_logical_emit_message() misses a XLogFlush() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: pg_logical_emit_message() misses a XLogFlush()
Date
Msg-id ZNv1IEHhGxrUTtwI@paquier.xyz
Whole thread Raw
In response to Re: pg_logical_emit_message() misses a XLogFlush()  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Responses Re: pg_logical_emit_message() misses a XLogFlush()
List pgsql-hackers
On Tue, Aug 15, 2023 at 11:37:32AM +0200, Tomas Vondra wrote:
> Shouldn't the flush be done only for non-transactional messages? The
> transactional case will be flushed by regular commit flush.

Indeed, that would be better.  I am sending an updated patch.

I'd like to backpatch that, would there be any objections to that?
This may depend on how much logical solutions depend on this routine.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Shaun Thomas
Date:
Subject: Logging of matching pg_hba.conf entry during auth skips trust auth, potential security issue
Next
From: Jelte Fennema
Date:
Subject: Would it be possible to backpatch Close support in libpq (28b5726) to PG16?