Re: Ignore 2PC transaction GIDs in query jumbling - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Ignore 2PC transaction GIDs in query jumbling
Date
Msg-id ZNq9kRwWbKzvR+2a@paquier.xyz
Whole thread Raw
In response to Re: Ignore 2PC transaction GIDs in query jumbling  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: Ignore 2PC transaction GIDs in query jumbling
List pgsql-hackers
On Mon, Aug 14, 2023 at 12:11:13PM +0100, Dagfinn Ilmari Mannsåker wrote:
> As far as I could tell the only thing missing was removing
> DeallocateStmt from the list of unhandled utility statement types (and
> updating comments to match).  Updated patch attached.

Hmm.  One issue with the patch is that we finish by considering
DEALLOCATE ALL and DEALLOCATE $1 as the same things, compiling the
same query IDs.  The difference is made in the Nodes by assigning NULL
to the name but we would now ignore it.  Wouldn't it be better to add
an extra field to DeallocateStmt to track separately the named
deallocate queries and ALL in monitoring?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: PG 16 draft release notes ready
Next
From: Masahiro Ikeda
Date:
Subject: Re: Support to define custom wait events for extensions