Re: Ignore 2PC transaction GIDs in query jumbling - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Ignore 2PC transaction GIDs in query jumbling
Date
Msg-id ZNh3XV2+cubcVaWk@paquier.xyz
Whole thread Raw
In response to Re: Ignore 2PC transaction GIDs in query jumbling  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Ignore 2PC transaction GIDs in query jumbling
List pgsql-hackers
On Tue, Aug 01, 2023 at 10:46:58AM +0800, Julien Rouhaud wrote:
> On Tue, Aug 01, 2023 at 11:37:49AM +0900, Michael Paquier wrote:
>> On Tue, Aug 01, 2023 at 10:22:09AM +0800, Julien Rouhaud wrote:
>>> Looking at the rest of the ignored patterns, the only remaining one would be
>>> DEALLOCATE, which AFAICS doesn't have a query_jumble_ignore tag for now.
>>
>> This one seems to be simple as well with a location field, looking
>> quickly at its Node.
>
> Agreed, it should be as trivial to implement as for the 2pc commands :)

Perhaps not as much, actually, because I was just reminded that
DEALLOCATE is something that pg_stat_statements ignores.  So this
makes harder the introduction of tests.  Anyway, I guess that your own
extension modules have a need for a query ID compiled with these
fields ignored?

For now, I have applied the 2PC bits independently, as of 638d42a.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: pg_waldump vs. all-zeros WAL files; server creation of such files
Next
From: Julien Rouhaud
Date:
Subject: Re: Ignore 2PC transaction GIDs in query jumbling