Add TLI number to name of files generated by pg_waldump --save-fullpage - Mailing list pgsql-hackers

From Michael Paquier
Subject Add TLI number to name of files generated by pg_waldump --save-fullpage
Date
Msg-id ZJp921+nITFnvBVS@paquier.xyz
Whole thread Raw
Responses Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
List pgsql-hackers
Hi all,
(Fujii-san and David in CC.)

Fujii-san has reported on Twitter that we had better add the TLI
number to what pg_waldump --save-fullpage generates for the file names
of the blocks, as it could be possible that we overwrite some blocks.
This information can be added thanks to ws_tli, that tracks the TLI of
the opened segment.

Attached is a patch to fix this issue, adding an open item assigned to
me.  The file format is documented in the TAP test and the docs, the
two only places that would need a refresh.

Thoughts or comments?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Honor PG_TEST_NOCLEAN for tempdirs
Next
From: Michael Paquier
Date:
Subject: Re: Clean up JumbleQuery() from query text