Re: [BUG] recovery of prepared transactions during promotion can fail - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [BUG] recovery of prepared transactions during promotion can fail
Date
Msg-id ZJADX9pvRpmX8i4G@paquier.xyz
Whole thread Raw
In response to Re: [BUG] recovery of prepared transactions during promotion can fail  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: [BUG] recovery of prepared transactions during promotion can fail  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Jun 19, 2023 at 02:41:54PM +0900, Kyotaro Horiguchi wrote:
> At Mon, 19 Jun 2023 14:24:44 +0900, Michael Paquier <michael@paquier.xyz> wrote in
>> On Fri, Jun 16, 2023 at 04:27:40PM +0200, Julian Markwort wrote:
>>> I've attached patches for PG 14 and PG 13 that mimic the change in
>>> PG15 (commit 811051c ) and reorder the crucial events, placing the
>>> recovery of prepared transactions *before* renaming the file.
>>
>> Yes, I think that's OK.  I would like to add two things to your
>> proposal for all the existing branches.
>> - Addition of a comment where RecoverPreparedTransactions() is called
>> at the end of recovery to tell that we'd better do that before working
>> on the last partial segment of the old timeline.
>> - Enforce the use of archiving in 009_twophase.pl.
>
> Both look good to me.

Okay, cool.  Thanks for double-checking, so let's do something down to
13, then..
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Ronan Dunklau
Date:
Subject: Re: Use generation context to speed up tuplesorts
Next
From: Juan José Santamaría Flecha
Date:
Subject: Re: Inconsistent results with libc sorting on Windows