Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Using named captures in Catalog::ParseHeader() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Using named captures in Catalog::ParseHeader()
Date
Msg-id ZIkR3LzEUjCcK2CH@paquier.xyz
Whole thread Raw
In response to [PATCH] Using named captures in Catalog::ParseHeader()  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Using named captures in Catalog::ParseHeader()
List pgsql-hackers
Tree view 
On Thu, Jun 01, 2023 at 01:12:22PM +0100, Dagfinn Ilmari Mannsåker wrote:
> While I was rewriting the regexes I noticed that they were inconsistent
> about whether they accepted whitespace in the parameter lists, so I took
> the liberty to make them consistently allow whitespace after the opening
> paren and the commas, which is what most of them already did.

That's the business with \s* in CATALOG.  Is that right?  Indeed,
that's more consistent.

> I've verified that the generated postgres.bki is identical to before,
> and all tests pass.

I find that pretty cool.  Nice.  Patch looks OK from here.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)