Re: Improve logging when using Huge Pages - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Improve logging when using Huge Pages
Date
Msg-id ZIkGp8SMj2oL/YV4@paquier.xyz
Whole thread Raw
In response to Re: Improve logging when using Huge Pages  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Jun 13, 2023 at 02:50:30PM +0900, Michael Paquier wrote:
> +       Assert(strcmp("unknown", GetConfigOption("huge_pages_status", false, false)) != 0);
>
> Not sure that there is anything to gain with this assertion in
> CreateSharedMemoryAndSemaphores(), because this is pretty much what
> check_GUC_init() looks after?

There was a second thing that bugged me here.  Would it be worth
adding some checks on huge_pages_status to make sure that it is never
reported as unknown when the server is up and running?  I am not sure
what would be the best location for that because there is nothing
specific to huge pages in the tests yet, but authentication/ with
005_sspi.pl and a second one would do the job?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: add non-option reordering to in-tree getopt_long
Next
From: Noah Misch
Date:
Subject: Re: add non-option reordering to in-tree getopt_long