Re: WAL Insertion Lock Improvements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: WAL Insertion Lock Improvements
Date
Msg-id ZGq2sbyM26f/0KJS@paquier.xyz
Whole thread Raw
In response to Re: WAL Insertion Lock Improvements  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: WAL Insertion Lock Improvements
List pgsql-hackers
On Fri, May 19, 2023 at 08:34:16PM +0530, Bharath Rupireddy wrote:
> I get it. How about the following similar to what
> ProcessProcSignalBarrier() has?
>
> +     * Note that pg_atomic_exchange_u64 is a full barrier, so we're guaranteed
> +     * that the variable is updated before waking up waiters.
> +     */
>
> +     * Note that pg_atomic_exchange_u64 is a full barrier, so we're guaranteed
> +     * that the variable is updated before releasing the lock.
>       */
>
> Please find the attached v8 patch with the above change.

Simpler and consistent, nice.  I don't have much more to add, so I
have switched the patch as RfC.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: ERROR: wrong varnullingrels (b 5 7) (expected (b)) for Var 3/3
Next
From: jian he
Date:
Subject: Re: PG 16 draft release notes ready