Re: MERGE lacks ruleutils.c decompiling support!? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: MERGE lacks ruleutils.c decompiling support!?
Date
Msg-id ZFW/bs6KWmJvgp+d@paquier.xyz
Whole thread Raw
In response to Re: MERGE lacks ruleutils.c decompiling support!?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: MERGE lacks ruleutils.c decompiling support!?
List pgsql-hackers
On Fri, May 05, 2023 at 05:06:34PM -0400, Tom Lane wrote:
> I did a bit of review and more work on this:
>
> * Added the missing OVERRIDING support
>
> * Played around with the pretty-printing indentation
>
> * Improved test coverage, and moved the test to rules.sql where
> I thought it fit more naturally.
>
> I think we could probably commit this, though I've not tried it
> in v15 yet.

Seems rather OK..

+WHEN NOT MATCHED
+   AND s.a > 100
+   THEN INSERT (id, data) OVERRIDING SYSTEM VALUE
+   VALUES (s.a, DEFAULT)

About OVERRIDING, I can see that this is still missing coverage for
OVERRIDING USER VALUE.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Autogenerate some wait events code and documentation
Next
From: Tom Lane
Date:
Subject: Re: MERGE lacks ruleutils.c decompiling support!?