Re: Add n_tup_newpage_upd to pg_stat table views - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add n_tup_newpage_upd to pg_stat table views
Date
Msg-id ZBucLCxjnhWfe5ul@paquier.xyz
Whole thread Raw
In response to Re: Add n_tup_newpage_upd to pg_stat table views  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Wed, Mar 22, 2023 at 05:14:08PM -0700, Peter Geoghegan wrote:
> * Small adjustments to the documentation.
>
> Nearby related items were tweaked slightly to make everything fit
> together a bit better. For example, the description of n_tup_hot_upd
> is revised to make it obvious that n_tup_hot_upd counts row updates
> that can never get counted under the new n_tup_newpage_upd counter.

@@ -168,6 +168,7 @@ typedef struct PgStat_TableCounts
        PgStat_Counter t_tuples_updated;
        PgStat_Counter t_tuples_deleted;
        PgStat_Counter t_tuples_hot_updated;
+       PgStat_Counter t_tuples_newpage_updated;
        bool            t_truncdropped;

I have in the works something that's going to rename these fields to
not have the "t_" prefix anymore, to ease some global refactoring in
pgstatfuncs.c so as we have less repetitive code with the functions
that grab these counters.  I don't think that's something you need to
name without the prefix here, just a FYI that this is going to be
immediately renamed ;)
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Add pg_walinspect function with block info columns
Next
From: Andres Freund
Date:
Subject: Re: POC: Lock updated tuples in tuple_update() and tuple_delete()