Re: Combine pg_walinspect till_end_of_wal functions with others - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Combine pg_walinspect till_end_of_wal functions with others
Date
Msg-id ZBu/BSBmaFRzjp7m@paquier.xyz
Whole thread Raw
In response to Re: Combine pg_walinspect till_end_of_wal functions with others  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
On Thu, Mar 16, 2023 at 01:17:59PM +0530, Bharath Rupireddy wrote:
> FWIW, I rebased the tests tweaking patch and attached it here as v9.
> This should keep the pg_walinspect tests consistent across comments,
> spaces, new lines and using count(*) >= 1 for all successful function
> executions. Thoughts?

Mostly OK by me, so applied after tweaking a few tiny things.  The
rewrites of the queries where we should have more than one record and
the removal of count() for the failure cases have been kept as
proposed, as are most of the comments.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: adherent postgres
Date:
Subject: 回复: WAL Insertion Lock Improvements
Next
From: "Karl O. Pinc"
Date:
Subject: Re: doc: add missing "id" attributes to extension packaging page