Re: Raising the SCRAM iteration count - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Raising the SCRAM iteration count
Date
Msg-id ZB5GvYpoDvRSbUqW@paquier.xyz
Whole thread Raw
In response to Re: Raising the SCRAM iteration count  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Raising the SCRAM iteration count  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Fri, Mar 24, 2023 at 09:56:29AM +0100, Daniel Gustafsson wrote:
> I've actually ripped out the test in question in the attached v9 to have it
> ready and building green in CFbot.

While reading through v9, I have noticed a few things.

+-- Changing the SCRAM iteration count
+SET scram_iterations = 1024;
+CREATE ROLE regress_passwd9 PASSWORD 'alterediterationcount';

Perhaps scram_iterations should be reset once this CREATE ROLE is run
to not impact any tests after that?

+/*
+ * The number of iterations to use when generating new secrets.
+ */
+int            scram_sha_256_iterations;

This variable in auth-scram.c should be initialized to
SCRAM_SHA_256_DEFAULT_ITERATIONS.

+use IPC::Run qw(pump finish timer);

This can be removed.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: running logical replication as the subscription owner
Next
From: Andrey Borodin
Date:
Subject: Re: psql \watch 2nd argument: iteration count