Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET
Date
Msg-id Z9flafNlH4-1YSJW@paquier.xyz
Whole thread Raw
In response to RE: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET  (Bykov Ivan <i.bykov@modernsys.ru>)
List pgsql-hackers
On Mon, Mar 17, 2025 at 07:33:42AM +0000, Bykov Ivan wrote:
> See:
>
https://www.postgresql.org/message-id/flat/5ac172e0b77a4baba50671cd1a15285f%40localhost.localdomain#6c43f354f5f42d2a27e6824faa660a86
>
> Is it really worth spending extra execution time to increase entropy
> when we have non-NULL nodes?

The computed time is already quite cheap, so I'm not much worried
about that, FWIW.

> We could also add entropy if we see a change in the node->type value for
> non-NULL variants.

I am not sure to get this one.  The issue shows up if we have the same
Node computed successively as reported on this thread.  It would still
be a problem for different node types, though less likely, when two
nodes use with similar fields.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: Reducing memory consumed by RestrictInfo list translations in partitionwise join planning
Next
From: Daniil Davydov
Date:
Subject: Re: Forbid to DROP temp tables of other sessions