Postgres Pro
Downloads
Home   >   mailing lists

Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t" - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
Date
Msg-id YzFZzIMcDx7nQk24@paquier.xyz
Whole thread Raw
In response to [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"  ("kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>)
Responses Re: [small patch] Change datatype of ParallelMessagePending from "volatile bool" to "volatile sig_atomic_t"
List pgsql-hackers
Tree view 
On Mon, Sep 26, 2022 at 06:57:28AM +0000, kuroda.hayato@fujitsu.com wrote:
> While reviewing [1], I and Amit noticed that a flag ParallelMessagePending is defined
> as "volatile bool", but other flags set by signal handlers are defined as "volatile sig_atomic_t".
>
> How do you think?

You are right.  bool is not usually a problem in a signal handler, but
sig_atomic_t is the type we ought to use.  I'll go adjust that.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Rushabh Lathia
Date:
Subject: DROP OWNED BY is broken on master branch.
Next
From: Michael Paquier
Date:
Subject: Re: DROP OWNED BY is broken on master branch.