Re: Inconvenience of pg_read_binary_file() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Inconvenience of pg_read_binary_file()
Date
Msg-id YuTG6kPDyA2F0Han@paquier.xyz
Whole thread Raw
In response to Re: Inconvenience of pg_read_binary_file()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Inconvenience of pg_read_binary_file()
List pgsql-hackers
On Fri, Jul 29, 2022 at 11:35:36PM -0400, Tom Lane wrote:
> Hm.  I considered reading PG_VERSION instead, or postmaster.pid.
> PG_VERSION would be a very boring test case, but it should certainly
> be present in $PGDATA.

PG_VERSION would be simpler.  Looking at postmaster.pid would require
a lookup at external_pid_file, and as it is not set by default you
would need to add some extra logic in the tests where
external_pid_file = NULL <=> PGDATA/postmaster.pid.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: pg15b2: large objects lost on upgrade
Next
From: mahendrakar s
Date:
Subject: Re: A proposal for shared memory based backup infrastructure