Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
Date
Msg-id YtjXD5ChRdI3OBnH@paquier.xyz
Whole thread Raw
In response to Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
List pgsql-hackers
On Thu, Jul 21, 2022 at 09:54:05AM +0530, Amit Kapila wrote:
> Yeah, it is not very clear to me either. I think this won't be
> difficult to change one or another way depending on future needs. At
> this stage, it appeared to me that bitmask is a better way to
> represent this information but if you and other feels using enum is a
> better idea then I am fine with that as well.

Please don't get me wrong :)

I favor a bitmask over an enum here, as you do, with a clean
layer for those flags.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
Next
From: Michael Paquier
Date:
Subject: Re: Add LZ4 compression in pg_dump