Re: Making pg_rewind faster - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Making pg_rewind faster
Date
Msg-id YtZCNZUNQWifrqz2@paquier.xyz
Whole thread Raw
In response to Re: Making pg_rewind faster  (Justin Kwan <justinpkwan@outlook.com>)
List pgsql-hackers
On Mon, Jul 18, 2022 at 05:14:00PM +0000, Justin Kwan wrote:
> Thank you for taking a look at this and that sounds good. I will
> send over a patch compatible with Postgres v16.

+$node_2->psql(
+       'postgres',
+       "SELECT extract(epoch from modification) FROM pg_stat_file('pg_wal/000000010000000000000003');",
+       stdout => \my $last_common_tli1_wal_last_modified_at);
Please note that you should not rely on the FS-level stats for
anything that touches the WAL segments.  A rough guess about what you
could here to make sure that only the set of WAL segments you are
looking for is being copied over would be to either:
- Scan the logs produced by pg_rewind and see if the segments are
copied or not, depending on the divergence point (aka the last
checkpoint before WAL forked).
- Clean up pg_wal/ in the target node before running pg_rewind,
checking that only the segments you want are available once the
operation completes.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: System catalog documentation chapter
Next
From: Thomas Munro
Date:
Subject: Re: Windows now has fdatasync()