Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Only allow returning string types or bytea from json_serialize - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Only allow returning string types or bytea from json_serialize
Date
Msg-id YsgE3g3NNLRCEMcH@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Only allow returning string types or bytea from json_serialize  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: pgsql: Only allow returning string types or bytea from json_serialize
List pgsql-committers
Tree view 
On Fri, Jul 08, 2022 at 03:41:35PM +0900, Kyotaro Horiguchi wrote:
> I noticed that this introcues the following error message.
>
> +  errmsg("cannot use RETURNING type %s in JSON_SERIALIZE"
> +                                format_type_be(returning->typid)),
>
> However, the same file has the following error message.
>
> >             errmsg("cannot use RETURNING type %s in %s",
> >                    format_type_be(returning->typid), fname),
>
> So, couldn't we share the format string to reduce translatable
> messages?

Yeah, I think that you are right, so let's fix this.  If Andrew does
not show up, I'll take care of it.
--
Michael
Attachment

pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Adjust node serialization tag of A_Expr for consistency
Next
From: Robert Haas
Date:
Subject: pgsql: Preserve relfilenode of pg_largeobject and its index across pg_u