Re: PATCH: Add Table Access Method option to pgbench - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: PATCH: Add Table Access Method option to pgbench
Date
Msg-id Yr5IqaabVWeIwIM6@paquier.xyz
Whole thread Raw
In response to Re: PATCH: Add Table Access Method option to pgbench  (Michel Pelletier <michel@supabase.io>)
Responses Re: PATCH: Add Table Access Method option to pgbench
List pgsql-hackers
On Thu, Jun 30, 2022 at 01:07:53PM -0700, Michel Pelletier wrote:
> I've got CI setup and building and the tests now pass, I was missing a
> CASCADE in my test.  New patch attached:

The exact same patch has been proposed back in November 2020:
https://www.postgresql.org/message-id/0177f78c-4702-69c9-449d-93cc93c7f8c0@highgo.ca

And the conclusion back then is that one can already achieve this by
using PGOPTIONS:
PGOPTIONS='-c default_table_access_method=wuzza' pgbench [...]

So there is no need to complicate more pgbench, particularly when it
comes to partitioned tables where USING is not supported.  Your patch
touches this area of the client code to bypass the backend error.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Logging query parmeters in auto_explain
Next
From: Michael Paquier
Date:
Subject: Re: PATCH: Add Table Access Method option to pgbench