Re: Correct comment in ProcedureCreate() for pgstat_create_function() call. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.
Date
Msg-id Yn4EDN4ce27JIfn+@paquier.xyz
Whole thread Raw
In response to Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.  (Amul Sul <sulamul@gmail.com>)
Responses Re: Correct comment in ProcedureCreate() for pgstat_create_function() call.
List pgsql-hackers
On Fri, May 13, 2022 at 10:22:57AM +0530, Amul Sul wrote:
> Sorry, hit the send button too early :|

-   /* ensure that stats are dropped if transaction commits */
+   /* ensure that stats are dropped if transaction aborts */
    if (!is_update)
            pgstat_create_function(retval);

As of what pgstat_create_function() does to create the stats of a new
function in a transactional way, it looks like you are right.  Will
fix if there are no objections.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Mikael Kjellström
Date:
Subject: Re: recovery test failure on morepork with timestamp mystery
Next
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Compression dictionaries for JSONB