Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work. - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.
Date
Msg-id YkaUuhwppy2hiBi9@paquier.xyz
Whole thread Raw
In response to Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-bugs
On Thu, Mar 31, 2022 at 07:03:09PM +0800, Julien Rouhaud wrote:
> There's no such indication on IsWindowsVersionOrGreater(), but after seeing
> various comments on forums from angry people, it may be a hint that it behaves
> similarly.  I'm not sure what to do at this point, maybe just always use the
> flag (the PG_ version which may be 0), hoping that hopefully windows won't
> define it if it can't handle it?

Looking at the internals of versionhelpers.h, would it work to use as
arguments for IsWindowsVersionOrGreater() the following, in this
order?  As of:
- HIBYTE(_WIN32_WINNT_WINTHRESHOLD)
- LOBYTE(_WIN32_WINNT_WINTHRESHOLD)
- 1703

Just to drop an idea.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Michael Paquier
Date:
Subject: Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.
Next
From: Julien Rouhaud
Date:
Subject: Re: BUG #17448: In Windows 10, version 1703 and later, huge_pages doesn't work.