Re: Plug minor memleak in pg_dump - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Plug minor memleak in pg_dump
Date
Msg-id YgMtbuZEeX4gzXqK@paquier.xyz
Whole thread Raw
In response to Re: Plug minor memleak in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Plug minor memleak in pg_dump  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Re: Plug minor memleak in pg_dump  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Wed, Feb 02, 2022 at 10:06:13AM +0100, Daniel Gustafsson wrote:
> The leak itself is clearly not something to worry about wrt memory pressure.
> We do read into tmp and free it in other places in the same function though (as
> you note above), so for code consistency alone this is worth doing IMO (and it
> reduces the risk of static analyzers flagging this).
>
> Unless objected to I will go ahead with getting this committed.

Looks like you forgot to apply that?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: [PATCH] Add min() and max() aggregate functions for xid8