Re: XLogReadRecord() error in XlogReadTwoPhaseData() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Date
Msg-id Ye4M5U98cseJ6OoL@paquier.xyz
Whole thread Raw
In response to Re: XLogReadRecord() error in XlogReadTwoPhaseData()  (Noah Misch <noah@leadboat.com>)
Responses Re: XLogReadRecord() error in XlogReadTwoPhaseData()
List pgsql-hackers
On Sun, Jan 23, 2022 at 06:10:07PM -0800, Noah Misch wrote:
> Could do that.  Every run that doesn't get the flaky failure will print a
> message like "TODO passed:  3-5", though the test file could mitigate that by
> declaring the TODO only on configurations where we expect a failure.  The
> 027_stream_regress.pl trouble involves reaching a die(), not failing a test in
> this sense, so that one would take more work.

Using a TODO has the advantage to allow the tests to run on a periodic
basis, even if they could fail in this unexpected way.  We've had our
load of issues in the past proper to specific architectures, so this
could help with the 2PC code paths and SPARC.  Not to mention that we
could just let the code be as-is, and it would fix itself once the
kernel is updated.  So that sounds much better to me than a skip
phase.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Next
From: Tom Lane
Date:
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()