Postgres Pro
Downloads
Home   >   mailing lists

Re: An obsolete comment of pg_stat_statements - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: An obsolete comment of pg_stat_statements
Date
Msg-id YcW2wlaKjrsEtfRj@paquier.xyz
Whole thread Raw
In response to Re: An obsolete comment of pg_stat_statements  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: An obsolete comment of pg_stat_statements  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Fri, Dec 24, 2021 at 03:32:10PM +0900, Kyotaro Horiguchi wrote:
> Thanks! Looks better.  It is used as-is in the attached.
>
> And I will register this to the next CF.

Do we really need to have this comment in the function header?  The
same is explained a couple of lines down so this feels like a
duplicate, and it is hard to miss it with the code shaped as-is (aka
the relationship between compute_query_id and queryId and the
consequences on what's stored in this case).
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Throttling WAL inserts when the standby falls behind more than the configured replica_lag_in_bytes
Next
From: Bharath Rupireddy
Date:
Subject: Re: Add checkpoint and redo LSN to LogCheckpointEnd log message