On Sun, Nov 21, 2021 at 08:45:52AM +0530, Bharath Rupireddy wrote:
> I don't think we need to go far to contrib/test_decoding/, even if we
> add it there we can't test it for the outputs of these functions, so
> I've added the tests in misc_functinos.sql itself.
+SELECT COUNT(*) >= 0 AS OK FROM pg_ls_replslotdir('slot_dir_funcs');
+ ok
+----
+ t
+(1 row)
Creating a slot within the main regression test suite is something we
should avoid as it impacts the portability of the tests (note that we
don't have tests creating slots in src/test/regress/, and we'd require
max_replication_slots > 0 with this version of the patch). This was
the point I was trying to make upthread about using test_decoding/
where we already have slots.
A second thing I have noticed is the set of OIDs used by the patch
which was incorrect. On a development branch, we require new features
to use OIDs between 8000-9999 (unused_oids would recommend a random
range of them). A third thing was that pg_proc.dat had an incorrect
description for pg_ls_replslotdir(), and that it was in need of
indentation.
I have tweaked a bit the tests and the docs, and the result looked
fine at the end. Hence, applied.
--
Michael
