Hi Robert,
On Fri, Nov 05, 2021 at 04:55:52PM +0000, Robert Haas wrote:
> Change ThisTimeLineID from a global variable to a local variable.
>
> StartupXLOG() still has ThisTimeLineID as a local variable, but the
> remaining code in xlog.c now needs to the relevant TimeLineID by some
> other means. Mostly, this means that we now pass it as a function
> parameter to a bunch of functions where we didn't previously.
> However, a few cases require special handling:
lapwing looks unhappy after this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2021-11-05%2022%3A40%3A10
xlog.c: In function 'StartupXLOG':
xlog.c:7249:5: error: 'checkPointLoc' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
xlog.c:6686:5: note: 'checkPointLoc' was declared here
Thanks,
--
Michael
