Re: inefficient loop in StandbyReleaseLockList() - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: inefficient loop in StandbyReleaseLockList()
Date
Msg-id YXuaLlYJxkmwnTDl@paquier.xyz
Whole thread Raw
In response to Re: inefficient loop in StandbyReleaseLockList()  (Andres Freund <andres@anarazel.de>)
Responses Re: inefficient loop in StandbyReleaseLockList()  ("Bossart, Nathan" <bossartn@amazon.com>)
List pgsql-hackers
On Thu, Oct 28, 2021 at 04:52:48PM -0700, Andres Freund wrote:
> I suspect the reverse lock order release could be tad faster. But I probably
> wouldn't change it either - I was more thinking of some of the other cases
> that deleted the first element, here it's a bit harder to know wether there's
> a chance of a CFI() or such.

Actually, as the list of recovery locks is saved in TopMemoryContext,
wouldn't it be better to keep a per-cell deletion of the list, which
would mean that we'd better do the operation in the reverse order to
make things faster with the new list implementation?  But that's what
Andres points at with CFIs in the middle of one list of the hash table
processed?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "tanghy.fnst@fujitsu.com"
Date:
Subject: RE: Added schema level support for publication.
Next
From: Masahiko Sawada
Date:
Subject: Re: Improve logging when using Huge Pages