Re: TAP test for recovery_end_command - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: TAP test for recovery_end_command
Date
Msg-id YXoCwLYC7ZlYGa1t@paquier.xyz
Whole thread Raw
In response to Re: TAP test for recovery_end_command  (Michael Paquier <michael@paquier.xyz>)
Responses Re: TAP test for recovery_end_command  (Amul Sul <sulamul@gmail.com>)
List pgsql-hackers
On Wed, Oct 27, 2021 at 02:20:50PM +0900, Michael Paquier wrote:
>  ok(!-f $recovery_end_command_file,
> -   'recovery_end_command executed after promotion');
> +   'recovery_end_command not executed yet');
> Indeed :p

While looking at that this morning, I have noticed an extra bug.  If
the path of the data folder included a space, the command would have
failed.  I have to wonder if we should do something like
cp_history_files, but that did not seem necessary to me once we rely
on each command being executed from the root of the data folder.

Anyway, I am curious to see what the buildfarm thinks about all that,
particularly with Msys, so I have applied the patch.  I am keeping an
eye on things, though.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] Fix memory corruption in pg_shdepend.c