Re: [PATCH] Fix memory corruption in pg_shdepend.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Fix memory corruption in pg_shdepend.c
Date
Msg-id YXeVfoH3Jtm/2CUq@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Mon, Oct 25, 2021 at 11:59:52AM -0400, Tom Lane wrote:
> I agree that we're not testing that area well enough.  Proposed
> patch seems basically OK, but I think the test needs to be stricter
> about what the expected output looks like --- for instance, it
> wouldn't complain if tab_foobar were described as something other
> than a table.

Indeed.  There was also a problem in the regex itself, where '|' was
not escaped so the regex was not strict enough.  While on it, I have
added a policy in the set copied to the new database.  Testing the
case where the set of slots is full would require 2300~ entries, that
would take some time..
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Shinya Kato
Date:
Subject: Re: CREATEROLE and role ownership hierarchies
Next
From: David Rowley
Date:
Subject: Re: jsonb crash