Re: [PATCH] Fix memory corruption in pg_shdepend.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Fix memory corruption in pg_shdepend.c
Date
Msg-id YXZh6EwFNOyrA0s3@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Fix memory corruption in pg_shdepend.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] Fix memory corruption in pg_shdepend.c
List pgsql-hackers
On Thu, Oct 21, 2021 at 11:42:31AM +0900, Michael Paquier wrote:
> It is easy enough to get an error on the new database with
> pg_describe_object().  Your part about adding a shared dependency with
> a table on a given role is simple enough, as well.  While looking for
> a place where to put such a test, 020_createdb.pl felt like a natural
> place and we don't have any coverage for the case of TEMPLATE with
> createdb.  So I would like to suggest something like the attached for
> HEAD.

I was thinking on this one over the last couple of days, and doing a
copy of shared deps from a template within createdb still feels
natural, as of this patch:
https://www.postgresql.org/message-id/YXDTl+PfSnqmbbkE@paquier.xyz

Would somebody object to the addition of this test?  Or perhaps
somebody has a better idea?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Improve the HINT message of the ALTER command for postgres_fdw
Next
From: Michael Paquier
Date:
Subject: Re: pg_receivewal starting position