On Fri, Oct 22, 2021 at 04:39:37PM +0300, Aleksander Alekseev wrote:
> I propose keeping only one of these procedures to simplify navigating
> through the code and debugging, and maybe saving a CPU cycle or two. A
> search for MakeTupleTableSlot produced 8 matches across 2 files, while
> MakeSingleTupleTableSlot is used 41 times across 26 files. Thus the
> proposed patch removes MakeTupleTableSlot and keeps
> MakeSingleTupleTableSlot to keep the patch less invasive and simplify
> backporting of the other patches. Hopefully, this will not complicate
> the life of the extension developers too much.
To make the life of extension developers easier, we could as well have
a compatibility macro so as anybody using MakeTupleTableSlot() won't
be annoyed by this change. However, looking around, this does not
look like a popular API so I'd be fine with your change as proposed.
Other opinions?
--
Michael
