Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY[ - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY[
Date
Msg-id YX9XLOYc2kjejZ1g@paquier.xyz
Whole thread Raw
In response to Re: Opclass parameters of indexes lost after REINDEX CONCURRENTLY  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Sat, Oct 30, 2021 at 09:26:35PM +0900, Michael Paquier wrote:
> Yeah, you are right that it would be better here to use
> get_attoptions() to grab a copy of each attribute's option directly
> from the catalogs.  We also do that for predicates and expressions.

While looking again at this one this morning, I have extended the
tests with more columns and some default values, then applied the
patch by using get_attoptions() to grab each attribute's options as of
add5cf2.  Predicates and expressions are grabbed through the syscache,
so that's just more consistent.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: inefficient loop in StandbyReleaseLockList()
Next
From: "wangsh.fnst@fujitsu.com"
Date:
Subject: make update-po problem with USE_PGXS