Re: Lost logs with csvlog redirected to stderr under WIN32 service - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Lost logs with csvlog redirected to stderr under WIN32 service
Date
Msg-id YV+zlwBJxIGYhJpA@paquier.xyz
Whole thread Raw
In response to Re: Lost logs with csvlog redirected to stderr under WIN32 service  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Thu, Oct 07, 2021 at 01:26:46PM +0900, Michael Paquier wrote:
> On Wed, Oct 06, 2021 at 09:33:24PM -0500, Chris Bandy wrote:
>>> +    /* Write to CSV log, if enabled */
>>> +    if ((Log_destination & LOG_DESTINATION_CSVLOG) != 0)
>>
>> This was originally "if (Log_destination & LOG_DESTINATION_CSVLOG)" and
>> other conditions nearby still lack the "!= 0". Whatever the preferred
>> style, the lines touched by this patch should probably do this consistently.
>
> Yeah.  It looks like using a boolean expression here is easier for my
> brain.

I have played with this patch more this morning, adjusted this part,
and applied it as of 8b76f89.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Next
From: Stephen Frost
Date:
Subject: Re: storing an explicit nonce