Re: pgsql: Support "postgres -C" with runtime-computed GUCs - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Date
Msg-id YUUiYvhR+Kpuafj+@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Support "postgres -C" with runtime-computed GUCs  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Support "postgres -C" with runtime-computed GUCs
List pgsql-committers
On Fri, Sep 17, 2021 at 03:18:38PM -0400, Andrew Dunstan wrote:
> The fixups for command_checks_all should go before the loops, not inside
> them.

Right.

> I would probably add a single line like this just after the call that
> checks the status:
>
>    foreach ($stderr, $stdout) { s/\r\n/\n/g if $Config{osname} eq 'msys'; }

Yes, that works.  Fine by me to use this grammar.

> although maybe perltidy would reformat that.

And perltidy tells me nothing here.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: pageinspect: Make page deletion elog less chatty.
Next
From: Michael Paquier
Date:
Subject: pgsql: Improve some check logic in pg_receivewal