Re: [PATCH] Tab completion for ALTER TABLE … ADD … - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Tab completion for ALTER TABLE … ADD …
Date
Msg-id YSwsmd44F3tjFyLI@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Tab completion for ALTER TABLE … ADD …  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Tab completion for ALTER TABLE … ADD …
List pgsql-hackers
On Fri, Aug 27, 2021 at 11:52:33AM +0100, Dagfinn Ilmari Mannsåker wrote:
> That was easy enough to add (just a bit of extra fiddling to handle
> COLUMN being optional), done in the attached v2 patch.

This part was a bit misleading, as it would recommend a list of types
when specifying just ADD CONSTRAINT for example, so I have removed
it.  An extra thing that felt a bit overdoing is the addition of KEY
after PRIMARY/FOREIGN.

> Doing a list of arbitrarily many comma-separated names is more
> complicated, so that can be the subject for another patch.

No objections to that.  I have applied what we have now, as that's
already an improvement.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: Write visibility map during CLUSTER/VACUUM FULL
Next
From: Masahiko Sawada
Date:
Subject: Re: Separate out FileSet from SharedFileSet (was Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o)