Re: return correct error code from pgtls_init - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: return correct error code from pgtls_init
Date
Msg-id YRs3c7CBwshznFAE@paquier.xyz
Whole thread Raw
In response to Re: return correct error code from pgtls_init  (Zhihong Yu <zyu@yugabyte.com>)
List pgsql-hackers
On Tue, Jun 01, 2021 at 06:56:42PM -0700, Zhihong Yu wrote:
> Looking at the -1 return, e.g.
>
>             pq_lockarray = malloc(sizeof(pthread_mutex_t) *
> CRYPTO_num_locks());
>
> when pq_lockarray is NULL. We can return errno.
>
> I didn't change call to pthread_mutex_lock() because PGTHREAD_ERROR() is
> used which aborts.

I am not sure what you mean here, and there is nothing wrong with this
code as far as I know, as we would let the caller of pgtls_init() know
that something is wrong.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: "李杰(慎追)"
Date:
Subject: A problem in ExecModifyTable
Next
From: "Bossart, Nathan"
Date:
Subject: Re: archive status ".ready" files may be created too early