Postgres Pro
Downloads
Home   >   mailing lists

Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date
Msg-id YOul6rcXvcowy78N@paquier.xyz
Whole thread Raw
In response to Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
On Sat, Jul 10, 2021 at 07:09:10PM +0530, Bharath Rupireddy wrote:
> Thanks. The patch looks good to me, except a minor comment - isn't it
> "int2 for these fields" as the fields still exist? + /* pageinspect >=
> 1.10 uses int4 instead of int2 for those fields */

This comment looks fine to me as-is, so applied on HEAD.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Greg Nancarrow
Date:
Subject: Re: row filtering for logical replication
Next
From: David Rowley
Date:
Subject: Re: Record a Bitmapset of non-pruned partitions