Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove repeated calls to PQserverVersion - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Remove repeated calls to PQserverVersion
Date
Msg-id YO1sxx0yIFd/f2jn@paquier.xyz
Whole thread Raw
In response to Remove repeated calls to PQserverVersion  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Remove repeated calls to PQserverVersion  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tree view 
On Tue, Jul 13, 2021 at 07:02:27PM +1000, Peter Smith wrote:
> I found a few functions making unnecessary repeated calls to
> PQserverVersion(conn); instead of just calling once and assigning to a
> local variable.

Does it really matter?  PQserverVersion() does a simple lookup at the
internals of PGconn.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] Pull general SASL framework out of SCRAM
Next
From: Dean Rasheed
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error