Re: [PATCH] Pull general SASL framework out of SCRAM - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] Pull general SASL framework out of SCRAM
Date
Msg-id YNZ5Bqq4GvhNvbp0@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] Pull general SASL framework out of SCRAM  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] Pull general SASL framework out of SCRAM
List pgsql-hackers
On Fri, Jun 25, 2021 at 11:40:33PM +0000, Jacob Champion wrote:
> I can definitely move it (into, say, auth-sasl.c?). I'll probably do
> that in a second commit, though, since keeping it in place during the
> refactor makes the review easier IMO.

auth-sasl.c is a name consistent with the existing practice.

> Can do. Does libpq-int-sasl.h work as a filename? This should not be
> exported to applications.

I would still with the existing naming used by fe-gssapi-common.h, so
that would be fe-auth-sasl.c and fe-auth-sasl.h, with the header
remaining internal.  Not strongly wedded to this name, of course, that
just seems consistent.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [patch] remove strver's leftover from error message in Solution.pm
Next
From: Michael Paquier
Date:
Subject: Re: Some incorrect logs in TAP tests of pgbench