Re: Error on pgbench logs - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Error on pgbench logs
Date
Msg-id YMMBbVVIQgs9B5oK@paquier.xyz
Whole thread Raw
In response to Re: Error on pgbench logs  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: Error on pgbench logs
Re: Error on pgbench logs
List pgsql-hackers
On Thu, Jun 10, 2021 at 11:29:30PM +0200, Fabien COELHO wrote:
> +        /* flush remaining stats */
> +        if (!logged && latency == 0.0)
> +            logAgg(logfile, agg);

You are right, this is missing the final stats.  Why the choice of
latency here for the check?  That's just to make the difference
between the case where doLog() is called while processing the
benchmark for the end of the transaction and the case where doLog() is
called once a thread ends, no?  Wouldn't it be better to do a final
push of the states once a thread reaches CSTATE_FINISHED or
CSTATE_ABORTED instead?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Question about StartLogicalReplication() error path
Next
From: Amit Langote
Date:
Subject: Re: Multi-Column List Partitioning