Re: installcheck failure in indirect_toast with default_toast_compression = lz4 - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: installcheck failure in indirect_toast with default_toast_compression = lz4
Date
Msg-id YLrWS/bZxnwI22Dv@paquier.xyz
Whole thread Raw
In response to Re: installcheck failure in indirect_toast with default_toast_compression = lz4  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Jun 04, 2021 at 08:28:59PM -0400, Tom Lane wrote:
> Hmm.  I'm not very clear on what that test is intending to test,
> but maybe it's dependent on pglz compression, in which case the
> right fix would be to force default_toast_compression = pglz
> for the duration of the test.

Support for external toast datums, as of 36820250, so that should be
independent on the compression method used, no?  I was just sticking
some checks based on pg_column_compression() all over the test, and
all the values are correctly getting compressed and decompressed as
far as I can see.

I got to wonder whether this is not pointing at an actual issue, and
whether it may be better to not make this test rely only on pglz, but
I have not put much thoughts into it TBH.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: A new function to wait for the backend exit after termination
Next
From: Michael Paquier
Date:
Subject: Re: alter table set TABLE ACCESS METHOD