Postgres Pro
Downloads
Home   >   mailing lists

Re: Fixup some appendStringInfo and appendPQExpBuffer calls - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date
Msg-id YLcJJnSz6YR7IMkz@paquier.xyz
Whole thread Raw
In response to Fixup some appendStringInfo and appendPQExpBuffer calls  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Responses Re: Fixup some appendStringInfo and appendPQExpBuffer calls  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Jun 02, 2021 at 01:37:51AM +0000, houzj.fnst@fujitsu.com wrote:
> In the latest HEAD branch, I found some places were using
> appendStringInfo/appendPQExpBuffer() when they could have been using
> appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better
> fix these places in case other developers will use these codes as a reference,
> though, it seems will not bring noticeable performance gain.

Indeed, that's the same thing as 110d817 to make all those calls
cheaper.  No objections from me to do those changes now rather than
later on HEAD.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Decoding speculative insert with toast leaks memory
Next
From: Michael Paquier
Date:
Subject: Re: Speed up pg_checksums in cases where checksum already set