Re: be-secure-gssapi.c and auth.c with setenv() not compatible on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: be-secure-gssapi.c and auth.c with setenv() not compatible on Windows
Date
Msg-id YLQqbG75bfe0lmvG@paquier.xyz
Whole thread Raw
In response to Re: be-secure-gssapi.c and auth.c with setenv() not compatible on Windows  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: be-secure-gssapi.c and auth.c with setenv() not compatible on Windows
List pgsql-hackers
On Sat, May 29, 2021 at 10:44:14AM -0400, Tom Lane wrote:
> What I had in mind was to *only* add pgwin32_setenv, not setenv.c.
> There's no evidence that any other modern platform lacks setenv.
> Moreover, there's no issue in these branches unless your platform
> lacks setenv yet has GSS support.

I have been finally able to poke at that, resulting in the attached.
You are right that adding only the fallback implementation for
setenv() seems to be enough.  I cannot get my environment to complain,
and the code compiles.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: postgres_fdw batching vs. (re)creating the tuple slots
Next
From: Masahiko Sawada
Date:
Subject: Re: Teaching users how they can get the most out of HOT in Postgres 14