Re: Move pg_attribute.attcompression to earlier in struct for reduced size? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date
Msg-id YKyPM6UC+tBHEuxo@paquier.xyz
Whole thread Raw
In response to Re: Move pg_attribute.attcompression to earlier in struct for reduced size?  (Dilip Kumar <dilipbalaut@gmail.com>)
Responses Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
List pgsql-hackers
On Mon, May 24, 2021 at 02:46:11PM +0530, Dilip Kumar wrote:
> Like this.
>   if (TupleDescAttr(newTupDesc, i)->attisdropped)
>      isnull[i] = true;
>   else
>      tup_values[i] = values[i];

That would work.  Your suggestion, as I understood it first, makes the
code simpler by not using tup_values at all as the set of values[] is
filled when the values and nulls are extracted.  So I have gone with
this simplification, and applied the patch (moved a bit the comments
while on it).
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Next
From: Bharath Rupireddy
Date:
Subject: Re: Skipping logical replication transactions on subscriber side